Skip to content

Commit

Permalink
doc: mention adding Fixes to collaborator onboarding PR
Browse files Browse the repository at this point in the history
Also update the example to include the Fixes url.

PR-URL: #37097
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
  • Loading branch information
joyeecheung authored and Lxxyx committed Jan 27, 2021
1 parent 4e833b6 commit 35fe310
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,14 @@ needs to be pointed out separately during the onboarding.
## Exercise: Make a PR adding yourself to the README

* Example:
<https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0>
* For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0
-1`
<https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8>
* For raw commit message:
`git show --format=%Bb58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8`
* Collaborators are in alphabetical order by GitHub username.
* Optionally, include your personal pronouns.
* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
so that when the commit lands, the nomination issue url will be
automatically closed.
* Label your pull request with the `doc`, `notable-change`, and `fast-track`
labels.
* Run CI on the PR. Use the `node-test-pull-request` CI task.
Expand Down

0 comments on commit 35fe310

Please sign in to comment.