Skip to content

Commit

Permalink
test: add mustCall() to test-inspector-contexts
Browse files Browse the repository at this point in the history
In test-inspector-contexts, if mainContextPromise is modified such that
the `method` argument is changed to something invalid, the test still
passes and the second part of the test never runs. Use
`common.mustCall()` to cause the test to fail if the second part of the
test does not run.

Refs: #30519 (comment)

PR-URL: #30649
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and addaleax committed Nov 30, 2019
1 parent 0972fa3 commit 3769632
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/sequential/test-inspector-contexts.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,4 @@ async function testBreakpointHit() {
await pausedPromise;
}

testContextCreatedAndDestroyed().then(testBreakpointHit);
testContextCreatedAndDestroyed().then(common.mustCall(testBreakpointHit));

0 comments on commit 3769632

Please sign in to comment.