Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "core: set PROVIDER type as Persistent class id"
This reverts commit 3c44100. Reverted for breaking node-heapdump[0]. AsyncWrap assigns a class id but does not set a v8::RetainedObjectInfo provider callback with v8::HeapProfiler::SetWrapperClassInfoProvider(). The result is a null pointer dereference when taking a heap snapshot. It can probably be solved by setting a generic provider callback inside the AsyncWrap constructor but that may have performance ramifications that need to be investigated first. I move to revert it for now. [0] https://github.com/bnoordhuis/node-heapdump PR-URL: #1827 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
- Loading branch information