Skip to content

Commit

Permalink
deps: disable avx512 for simutf on benchmark ci
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel Lemire <daniel@lemire.me>
  • Loading branch information
anonrig and lemire committed Dec 19, 2022
1 parent f4ea2cd commit 3a54f7d
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions deps/simdutf/simdutf.gyp
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
{
'variables': {
'gas_version%': '0.0',
'nasm_version%': '0.0',
'llvm_version%': '0.0',
},
'targets': [
{
'target_name': 'simdutf',
Expand All @@ -8,6 +13,16 @@
'include_dirs': ['.'],
},
'sources': ['simdutf.cpp'],
'conditions': [
['OS=="linux"', {
'conditions': [
# TODO(anonrig): Remove this validation when benchmark CI has binutils >= 2.30
['v(gas_version) < v("2.30") and v(nasm_version) < v("2.14") and v(llvm_version) < v("6.0")', {
'defines': ['SIMDUTF_IMPLEMENTATION_ICELAKE=0'],
}],
],
}],
],
},
]
}

1 comment on commit 3a54f7d

@jclaudioandrade
Copy link

@jclaudioandrade jclaudioandrade commented on 3a54f7d Mar 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me with Dual-Core AMD Opteron(tm) Processor 1210 without AVX-512 instructions.
I had the error "/tmp/ccjmqJ34.s:6337: Error: no such instruction: `vpcompressb %zmm6,%zmm9{%k2}{z}'"
With your adiction, I sucessfuly compile my node-v18.15.0 using gcc-8.3.0

Please sign in to comment.