src: return error --env-file if file is not found

src/node.cc

@@ -866,7 +866,10 @@ static ExitCode InitializeNodeWithArgsInternal(
 
  for (const auto& file_path : file_paths) {
  std::string path = cwd + kPathSeparator + file_path;
- per_process::dotenv_file.ParsePath(path);
+ auto file_is_exist = per_process::dotenv_file.ParsePath(path);
+
+ if (!file_is_exist)
+ errors->push_back(std::string(file_path) + ": not found");
  }
 
  per_process::dotenv_file.AssignNodeOptionsIfAvailable(&node_options);

src/node_dotenv.cc

@@ -64,14 +64,14 @@ void Dotenv::SetEnvironment(node::Environment* env) {
  }
 }
 
-void Dotenv::ParsePath(const std::string_view path) {
+bool Dotenv::ParsePath(const std::string_view path) {
  uv_fs_t req;
  auto defer_req_cleanup = OnScopeLeave([&req]() { uv_fs_req_cleanup(&req); });
 
  uv_file file = uv_fs_open(nullptr, &req, path.data(), 0, 438, nullptr);
  if (req.result < 0) {
  // req will be cleaned up by scope leave.
- return;
+ return false;
  }
  uv_fs_req_cleanup(&req);
 
@@ -87,10 +87,6 @@ void Dotenv::ParsePath(const std::string_view path) {
 
  while (true) {
  auto r = uv_fs_read(nullptr, &req, file, &buf, 1, -1, nullptr);
- if (req.result < 0) {
- // req will be cleaned up by scope leave.
- return;
- }
  uv_fs_req_cleanup(&req);
  if (r <= 0) {
  break;

src/node_dotenv.h

@@ -18,7 +18,7 @@ class Dotenv {
  Dotenv& operator=(const Dotenv& d) = default;
  ~Dotenv() = default;
 
- void ParsePath(const std::string_view path);
+ bool ParsePath(const std::string_view path);
  void AssignNodeOptionsIfAvailable(std::string* node_options);
  void SetEnvironment(Environment* env);
 

test/parallel/test-dotenv-edge-cases.js

@@ -34,7 +34,8 @@ describe('.env supports edge cases', () => {
  [ '--env-file=.env', '--eval', code ],
  { cwd: __dirname },
  );
- assert.strictEqual(child.stderr, '');
+ assert.strictEqual(child.stderr.toString().includes('node: .env: not found\n'), true);
+ assert.strictEqual(child.code, 9);
  assert.strictEqual(child.code, 0);
  });