src: don't include a null character in the WriteConsoleW call

Fixes: #7755 PR-URL: #7764 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
nodejs · Aug 24, 2016 · 4118598 · 4118598
1 parent 92de0bc
commit 4118598
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/node.cc b/src/node.cc
@@ -258,7 +258,10 @@ static void PrintErrorString(const char* format, ...) {
 
   std::vector<wchar_t> wbuf(n);
   MultiByteToWideChar(CP_UTF8, 0, out.data(), -1, wbuf.data(), n);
-  WriteConsoleW(stderr_handle, wbuf.data(), n, nullptr, nullptr);
+
+  // Don't include the null character in the output
+  CHECK_GT(n, 0);
+  WriteConsoleW(stderr_handle, wbuf.data(), n - 1, nullptr, nullptr);
 #else
   vfprintf(stderr, format, ap);
 #endif