Skip to content

Commit

Permalink
test: reverse arguments in assert.strictEqual
Browse files Browse the repository at this point in the history
assert.strictEqual() had incorrect order of arguments with expected and
actual values reversed.

PR-URL: #23613
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
past5 authored and addaleax committed Oct 20, 2018
1 parent 20d4cba commit 43c2aa3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/parallel/test-http-keep-alive-close-on-header.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ server.listen(0, function() {
port: this.address().port,
agent: agent
}, function(res) {
assert.strictEqual(1, agent.sockets[name].length);
assert.strictEqual(agent.sockets[name].length, 1);
res.resume();
});
request.on('socket', function(s) {
Expand All @@ -63,7 +63,7 @@ server.listen(0, function() {
port: this.address().port,
agent: agent
}, function(res) {
assert.strictEqual(1, agent.sockets[name].length);
assert.strictEqual(agent.sockets[name].length, 1);
res.resume();
});
request.on('socket', function(s) {
Expand All @@ -80,7 +80,7 @@ server.listen(0, function() {
agent: agent
}, function(response) {
response.on('end', function() {
assert.strictEqual(1, agent.sockets[name].length);
assert.strictEqual(agent.sockets[name].length, 1);
server.close();
});
response.resume();
Expand All @@ -94,5 +94,5 @@ server.listen(0, function() {
});

process.on('exit', function() {
assert.strictEqual(3, connectCount);
assert.strictEqual(connectCount, 3);
});

0 comments on commit 43c2aa3

Please sign in to comment.