Skip to content

Commit

Permalink
tools: fix use-after-free mkcodecache warning
Browse files Browse the repository at this point in the history
Call `v8::Platform::ShutdownPlatform()` to fix a Coverity warning about
the `v8::Platform` instance being deleted when it's still in use.

PR-URL: #27332
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
bnoordhuis authored and targos committed Apr 27, 2019
1 parent f0b2992 commit 481789c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/code_cache/mkcodecache.cc
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,6 @@ int main(int argc, char* argv[]) {
out.close();
}

v8::V8::ShutdownPlatform();
return 0;
}

0 comments on commit 481789c

Please sign in to comment.