Skip to content

Commit

Permalink
test: update postmortem metadata test for V8 7.4
Browse files Browse the repository at this point in the history
Summary of changes:

- v8dbg_class_FixedTypedArrayBase__external_pointer__Object
  - Type changed in v8/v8@f70bb59#diff-f3f182b0510ba2ee39ae87e421ff110b.
  - Use v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t
- v8dbg_class_JSArrayBuffer__backing_store__Object
  - Type changed in v8/v8@f70bb59#diff-f3f182b0510ba2ee39ae87e421ff110b.
  - Use v8dbg_class_JSArrayBuffer__backing_store__uintptr_t
- v8dbg_class_Map__raw_instance_descriptors__DescriptorArray
  - Changed in v8/v8@d7b08b6#diff-59788e25dc5196c356894d5e1fac6425
  - New constant added to V8: v8dbg_class_Map__instance_descriptors_offset
- v8dbg_PointerSizeLog2
  - Changed in v8/v8@46d1986#diff-f3f182b0510ba2ee39ae87e421ff110b
  - Refs: https://bugs.chromium.org/p/v8/issues/detail?id=8477
  - Use new constants: v8dbg_SystemPointerSize, v8dbg_SystemPointerSizeLog2,
        v8dbg_TaggedSize, and v8dbg_TaggedSizeLog2

PR-URL: #26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
cjihrig authored and BethGriggs committed Apr 4, 2019
1 parent 80b8988 commit 4e1e7c3
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions test/v8-updates/test-postmortem-metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ function getExpectedSymbols() {
'v8dbg_class_FixedArray__data__uintptr_t',
'v8dbg_class_FixedArrayBase__length__SMI',
'v8dbg_class_FixedTypedArrayBase__base_pointer__Object',
'v8dbg_class_FixedTypedArrayBase__external_pointer__Object',
'v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t',
'v8dbg_class_HeapNumber__value__double',
'v8dbg_class_HeapObject__map__Map',
'v8dbg_class_JSArray__length__Object',
'v8dbg_class_JSArrayBuffer__backing_store__Object',
'v8dbg_class_JSArrayBuffer__backing_store__uintptr_t',
'v8dbg_class_JSArrayBuffer__byte_length__size_t',
'v8dbg_class_JSArrayBufferView__buffer__Object',
'v8dbg_class_JSArrayBufferView__byte_length__size_t',
Expand All @@ -84,7 +84,7 @@ function getExpectedSymbols() {
'v8dbg_class_Map__constructor_or_backpointer__Object',
'v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char',
'v8dbg_class_Map__instance_type__uint16_t',
'v8dbg_class_Map__raw_instance_descriptors__DescriptorArray',
'v8dbg_class_Map__instance_descriptors_offset',
'v8dbg_class_Map__instance_size_in_words__char',
'v8dbg_class_Oddball__kind_offset__int',
'v8dbg_class_Script__line_ends__Object',
Expand Down Expand Up @@ -179,7 +179,10 @@ function getExpectedSymbols() {
'v8dbg_OddballUndefined',
'v8dbg_OddballUninitialized',
'v8dbg_OneByteStringTag',
'v8dbg_PointerSizeLog2',
'v8dbg_SystemPointerSize',
'v8dbg_SystemPointerSizeLog2',
'v8dbg_TaggedSize',
'v8dbg_TaggedSizeLog2',
'v8dbg_SeqStringTag',
'v8dbg_SlicedStringTag',
'v8dbg_SmiShiftSize',
Expand Down

0 comments on commit 4e1e7c3

Please sign in to comment.