Skip to content

Commit

Permalink
test: update postmortem metadata test
Browse files Browse the repository at this point in the history
This commit updates the following postmortem metadata constants:

- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
  - This is now
    v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
    as of
    v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
  - This is now v8dbg_class_Map__instance_type__uint16_t as of
    v8/v8@c00bb6d
    and
    v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
  - This is now v8dbg_class_Map__instance_size_in_words__char as of
    v8/v8@61bf2cc

Refs: nodejs/node-v8#34

PR-URL: #17489
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
  • Loading branch information
cjihrig authored and MylesBorins committed Jan 24, 2018
1 parent 3154d83 commit 4e51512
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions test/parallel/test-postmortem-metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ assert.strictEqual(missing.length, 0, `Missing constants: ${missing}`);
// pushed to the bottom of the file for improved readability.
function getExpectedSymbols() {
return [
// Disable the maximum line length for the remainder of the file since it
// should only consist of postmortem constants, and some of them can be
// relatively long.
/* eslint-disable max-len */
'v8dbg_bit_field3_dictionary_map_shift',
'v8dbg_bit_field3_number_of_own_descriptors_shift',
'v8dbg_class_Code__instruction_size__int',
Expand Down Expand Up @@ -64,10 +68,10 @@ function getExpectedSymbols() {
'v8dbg_class_JSRegExp__source__Object',
'v8dbg_class_Map__bit_field3__int',
'v8dbg_class_Map__constructor_or_backpointer__Object',
'v8dbg_class_Map__inobject_properties_or_constructor_function_index__int',
'v8dbg_class_Map__instance_attributes__int',
'v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char',
'v8dbg_class_Map__instance_type__uint16_t',
'v8dbg_class_Map__instance_descriptors__DescriptorArray',
'v8dbg_class_Map__instance_size__int',
'v8dbg_class_Map__instance_size_in_words__char',
'v8dbg_class_Oddball__kind_offset__int',
'v8dbg_class_Script__line_ends__Object',
'v8dbg_class_Script__line_offset__SMI',
Expand Down

0 comments on commit 4e51512

Please sign in to comment.