-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http: add maxTotalSockets to agent class
Add maxTotalSockets to determine how many sockets an agent can open. Unlike maxSockets, The maxTotalSockets does not count by per origin. PR-URL: #33617 Fixes: #31942 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
1 parent
fc7cad8
commit 507a2ef
Showing
3 changed files
with
171 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const http = require('http'); | ||
| const Countdown = require('../common/countdown'); | ||
|
|
||
| assert.throws(() => new http.Agent({ | ||
| maxTotalSockets: 'test', | ||
| }), { | ||
| code: 'ERR_INVALID_ARG_TYPE', | ||
| name: 'TypeError', | ||
| message: 'The "maxTotalSockets" argument must be of type number. ' + | ||
| "Received type string ('test')", | ||
| }); | ||
|
|
||
| [-1, 0, NaN].forEach((item) => { | ||
| assert.throws(() => new http.Agent({ | ||
| maxTotalSockets: item, | ||
| }), { | ||
| code: 'ERR_OUT_OF_RANGE', | ||
| name: 'RangeError', | ||
| message: 'The value of "maxTotalSockets" is out of range. ' + | ||
| `It must be > 0. Received ${item}`, | ||
| }); | ||
| }); | ||
|
|
||
| assert.ok(new http.Agent({ | ||
| maxTotalSockets: Infinity, | ||
| })); | ||
|
|
||
| function start(param = {}) { | ||
| const { maxTotalSockets, maxSockets } = param; | ||
|
|
||
| const agent = new http.Agent({ | ||
| keepAlive: true, | ||
| keepAliveMsecs: 1000, | ||
| maxTotalSockets, | ||
| maxSockets, | ||
| maxFreeSockets: 3 | ||
| }); | ||
|
|
||
| const server = http.createServer(common.mustCall((req, res) => { | ||
| res.end('hello world'); | ||
| }, 6)); | ||
| const server2 = http.createServer(common.mustCall((req, res) => { | ||
| res.end('hello world'); | ||
| }, 6)); | ||
|
|
||
| server.keepAliveTimeout = 0; | ||
| server2.keepAliveTimeout = 0; | ||
|
|
||
| const countdown = new Countdown(12, () => { | ||
| assert.strictEqual(getRequestCount(), 0); | ||
| agent.destroy(); | ||
| server.close(); | ||
| server2.close(); | ||
| }); | ||
|
|
||
| function handler(s) { | ||
| for (let i = 0; i < 6; i++) { | ||
| http.get({ | ||
| host: 'localhost', | ||
| port: s.address().port, | ||
| agent, | ||
| path: `/${i}`, | ||
| }, common.mustCall((res) => { | ||
| assert.strictEqual(res.statusCode, 200); | ||
| res.resume(); | ||
| res.on('end', common.mustCall(() => { | ||
| for (const key of Object.keys(agent.sockets)) { | ||
| assert(agent.sockets[key].length <= maxSockets); | ||
| } | ||
| assert(getTotalSocketsCount() <= maxTotalSockets); | ||
| countdown.dec(); | ||
| })); | ||
| })); | ||
| } | ||
| } | ||
|
|
||
| function getTotalSocketsCount() { | ||
| let num = 0; | ||
| for (const key of Object.keys(agent.sockets)) { | ||
| num += agent.sockets[key].length; | ||
| } | ||
| return num; | ||
| } | ||
|
|
||
| function getRequestCount() { | ||
| let num = 0; | ||
| for (const key of Object.keys(agent.requests)) { | ||
| num += agent.requests[key].length; | ||
| } | ||
| return num; | ||
| } | ||
|
|
||
| server.listen(0, common.mustCall(() => handler(server))); | ||
| server2.listen(0, common.mustCall(() => handler(server2))); | ||
| } | ||
|
|
||
| // If maxTotalSockets is larger than maxSockets, | ||
| // then the origin check will be skipped | ||
| // when the socket is removed. | ||
| [{ | ||
| maxTotalSockets: 2, | ||
| maxSockets: 3, | ||
| }, { | ||
| maxTotalSockets: 3, | ||
| maxSockets: 2, | ||
| }, { | ||
| maxTotalSockets: 2, | ||
| maxSockets: 2, | ||
| }].forEach(start); |