Skip to content

Commit

Permalink
deps: patch V8 to 12.4.254.19
Browse files Browse the repository at this point in the history
Refs: v8/v8@12.4.254.18...12.4.254.19
PR-URL: #53094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
  • Loading branch information
nodejs-github-bot authored and targos committed Jun 1, 2024
1 parent 2859f4c commit 52a7873
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 12
#define V8_MINOR_VERSION 4
#define V8_BUILD_NUMBER 254
#define V8_PATCH_LEVEL 18
#define V8_PATCH_LEVEL 19

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
13 changes: 7 additions & 6 deletions deps/v8/src/ic/ic.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2377,15 +2377,16 @@ Handle<Object> KeyedStoreIC::StoreElementHandler(
isolate()),
IsStoreInArrayLiteralIC());

if (IsJSProxyMap(*receiver_map)) {
if (!IsJSObjectMap(*receiver_map)) {
// DefineKeyedOwnIC, which is used to define computed fields in instances,
// should be handled by the slow stub.
if (IsDefineKeyedOwnIC()) {
TRACE_HANDLER_STATS(isolate(), KeyedStoreIC_SlowStub);
return StoreHandler::StoreSlow(isolate(), store_mode);
// should handled by the slow stub below instead of the proxy stub.
if (IsJSProxyMap(*receiver_map) && !IsDefineKeyedOwnIC()) {
return StoreHandler::StoreProxy(isolate());
}

return StoreHandler::StoreProxy(isolate());
// Wasm objects or other kind of special objects go through the slow stub.
TRACE_HANDLER_STATS(isolate(), KeyedStoreIC_SlowStub);
return StoreHandler::StoreSlow(isolate(), store_mode);
}

// TODO(ishell): move to StoreHandler::StoreElement().
Expand Down

0 comments on commit 52a7873

Please sign in to comment.