Skip to content

Commit

Permalink
doc: remove obsolete cc recommendations
Browse files Browse the repository at this point in the history
In 2016, Ali added the instruction to cc him on particular V8 bugs and
the suggestion to contact him for certain problems. However, I'm pretty
sure Ali has not been working on V8 for 2+ years at this point. I'm
guessing those instructions are obsolete at this point. (I'll ping him
in the PR for this change to confirm, though.)

Also: Remove a parenthetical and add a comma, because I can't imagine
opening a separate pull request to add a comma. (OK, I'm lying, I
totally can and if anyone has done that in the past, it's probably me.)

PR-URL: #39181
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott committed Jun 30, 2021
1 parent b11d3f1 commit 593212c
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions doc/guides/maintaining-V8.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ fixed upstream first.
### Backporting to active branches

If the bug exists in any of the active V8 branches, we may need to get the fix
backported. At any given time there are [two active branches][V8ActiveBranches]
backported. At any given time, there are [two active branches][V8ActiveBranches]
(beta and stable) in addition to master. The following steps are needed to
backport the fix:

Expand All @@ -191,9 +191,7 @@ backport the fix:
* If a bug already exists
* Add a reference to the GitHub issue.
* Attach *merge-request-x.x* labels to the bug for any active branches
that still contain the bug. (e.g. merge-request-5.3,
merge-request-5.4)
* Add ofrobots-at-google.com to the cc list.
that still contain the bug.
* Once the merge has been approved, it should be merged using the
[merge script documented in the V8 wiki][V8MergingPatching]. Merging requires
commit access to the V8 repository. If you don't have commit access you can
Expand Down Expand Up @@ -246,8 +244,7 @@ fix needed to be cherry-picked. To cherry-pick, here's an example workflow:
not apply cleanly. It may help to try to cherry-pick the merge to the oldest
branch that was done upstream in V8. In this example, this would be the patch
from the merge to 5.2. The hope is that this would be closer to the V8 5.1,
and has a better chance of applying cleanly. If you're stuck, feel free to
ping @ofrobots for help.
and has a better chance of applying cleanly.
* Modify the commit message to match the format we use for V8 backports and
replace yourself as the author. `git commit --amend --reset-author`. You may
want to add extra description if necessary to indicate the impact of the fix
Expand Down

0 comments on commit 593212c

Please sign in to comment.