Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR_URL: #3724 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com>
- Loading branch information
64208ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saghul @romankl @thealphanerd
Note: our tooling will recognize
PR_URL:
, but we preferPR-URL:
:)64208ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, gotta make the first mistake on second 1! I blame the reviewers :-P
64208ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUT WHO REVIEWS THE REVIEWERS
:P
64208ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't often do this, but it is possible to push this info up to the PR branch first before landing. Perhaps we should suggest that in #3726
(Don't worry, worse mistakes have been made by yours truly)