lib: fix DOMException property descriptors after being lazy loaded

PR-URL: #46799 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nodejs · Nov 10, 2023 · 671d2c0 · 671d2c0
1 parent cb6ef74
commit 671d2c0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/lib/internal/bootstrap/browser.js b/lib/internal/bootstrap/browser.js
@@ -26,7 +26,11 @@ exposeInterface(globalThis, 'URL', URL);
 exposeInterface(globalThis, 'URLSearchParams', URLSearchParams);
 exposeGetterAndSetter(globalThis,
                       'DOMException',
-                      lazyDOMExceptionClass,
+                      () => {
+                        const DOMException = lazyDOMExceptionClass();
+                        exposeInterface(globalThis, 'DOMException', DOMException);
+                        return DOMException;
+                      },
                       (value) => {
                         exposeInterface(globalThis, 'DOMException', value);
                       });

diff --git a/test/common/wpt.js b/test/common/wpt.js
@@ -503,6 +503,7 @@ class WPTRunner {
 
   loadLazyGlobals() {
     const lazyProperties = [
+      'DOMException',
       'Performance', 'PerformanceEntry', 'PerformanceMark', 'PerformanceMeasure',
       'PerformanceObserver', 'PerformanceObserverEntryList', 'PerformanceResourceTiming',
       'Blob', 'atob', 'btoa',

diff --git a/test/wpt/test-domexception.js b/test/wpt/test-domexception.js
@@ -4,15 +4,6 @@ const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('webidl/ecmascript-binding/es-exceptions');
 
-runner.setFlags(['--expose-internals']);
-runner.setInitScript(`
-  const { internalBinding } = require('internal/test/binding');
-  const { DOMException } = internalBinding('messaging');
-  Object.defineProperty(global, 'DOMException', {
-    writable: true,
-    configurable: true,
-    value: DOMException,
-  });
-`);
+runner.loadLazyGlobals();
 
 runner.runJsTests();