-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: fix DOMException property descriptors after being lazy loaded #46799
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
panva:fix-domexception-global-wpt
Feb 25, 2023
Merged
lib: fix DOMException property descriptors after being lazy loaded #46799
nodejs-github-bot
merged 2 commits into
nodejs:main
from
panva:fix-domexception-global-wpt
Feb 25, 2023
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 23, 2023
jasnell
approved these changes
Feb 24, 2023
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 24, 2023
legendecas
approved these changes
Feb 24, 2023
panva
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 24, 2023
joyeecheung
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion
joyeecheung
reviewed
Feb 24, 2023
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
panva
added
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Feb 24, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 24, 2023
tniessen
approved these changes
Feb 24, 2023
joyeecheung
approved these changes
Feb 24, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 25, 2023
Landed in f85113b |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46799 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46799 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
added
the
backport-requested-v18.x
PRs awaiting manual backport to the v18.x-staging branch.
label
Apr 11, 2023
@panva this also broke builds in the v18.x-staging branch. Could you open a backport PR? Thank you |
Backport depends on #46425 |
panva
added
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
and removed
backport-requested-v18.x
PRs awaiting manual backport to the v18.x-staging branch.
labels
Apr 11, 2023
targos
pushed a commit
that referenced
this pull request
Nov 10, 2023
PR-URL: #46799 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#46799 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#46799 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOMException property descriptors after they being lazy loaded the first time.