Skip to content

Commit

Permalink
Revert "deps: remove bogus V8 DCHECK"
Browse files Browse the repository at this point in the history
This reverts commit fba06eb.

PR-URL: #54682
Refs: v8/v8@12.8.374.22...12.8.374.31
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
targos authored and nodejs-github-bot committed Sep 11, 2024
1 parent 123bb4c commit 6bce6f6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.14',
'v8_embedder_string': '-node.15',

##### V8 defaults for Node.js #####

Expand Down
1 change: 1 addition & 0 deletions deps/v8/src/ast/scopes.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2713,6 +2713,7 @@ void Scope::AllocateScopeInfosRecursively(

// Allocate ScopeInfos for inner scopes.
for (Scope* scope = inner_scope_; scope != nullptr; scope = scope->sibling_) {
DCHECK_GT(scope->UniqueIdInScript(), UniqueIdInScript());
DCHECK_IMPLIES(scope->sibling_, scope->sibling_->UniqueIdInScript() !=
scope->UniqueIdInScript());
if (!scope->is_function_scope() ||
Expand Down

0 comments on commit 6bce6f6

Please sign in to comment.