process: make Symbol.toStringTag writable

The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: #26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Mar 14, 2019 · 727ade1 · 727ade1
1 parent f2eeb38
commit 727ade1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -350,7 +350,7 @@ function setupProcessObject() {
   EventEmitter.call(process);
   Object.defineProperty(process, Symbol.toStringTag, {
     enumerable: false,
-    writable: false,
+    writable: true,
     configurable: false,
     value: 'process'
   });

diff --git a/test/es-module/test-esm-process.mjs b/test/es-module/test-esm-process.mjs
@@ -4,3 +4,4 @@ import assert from 'assert';
 import process from 'process';
 
 assert.strictEqual(Object.prototype.toString.call(process), '[object process]');
+assert(Object.getOwnPropertyDescriptor(process, Symbol.toStringTag).writable);
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,3 +4,4 @@ import assert from 'assert';
		import process from 'process';

		assert.strictEqual(Object.prototype.toString.call(process), '[object process]');
		assert(Object.getOwnPropertyDescriptor(process, Symbol.toStringTag).writable);