-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
vm: don't abort process when stack space runs out
Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space. Ref: #6899 PR-URL: #6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
- Loading branch information
Showing
2 changed files
with
31 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
'use strict'; | ||
require('../common'); | ||
const assert = require('assert'); | ||
const vm = require('vm'); | ||
|
||
function a() { | ||
try { | ||
return a(); | ||
} catch (e) { | ||
// Throw an exception as near to the recursion-based RangeError as possible. | ||
return vm.runInThisContext('() => 42')(); | ||
} | ||
} | ||
|
||
assert.strictEqual(a(), 42); | ||
|
||
function b() { | ||
try { | ||
return b(); | ||
} catch (e) { | ||
// This writes a lot of noise to stderr, but it still works. | ||
return vm.runInNewContext('() => 42')(); | ||
} | ||
} | ||
|
||
assert.strictEqual(b(), 42); |