src: expose V8's IsNativeError() in util bindings

Refs: #12400 PR-URL: #12546 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · May 2, 2017 · 744ed94 · 744ed94
1 parent 51eafe8
commit 744ed94
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/node_util.cc b/src/node_util.cc
@@ -24,6 +24,7 @@ using v8::Value;
   V(isDate, IsDate)                                                           \
   V(isMap, IsMap)                                                             \
   V(isMapIterator, IsMapIterator)                                             \
+  V(isNativeError, IsNativeError)                                             \
   V(isPromise, IsPromise)                                                     \
   V(isRegExp, IsRegExp)                                                       \
   V(isSet, IsSet)                                                             \

diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js
@@ -2,6 +2,7 @@
 const common = require('../common');
 const assert = require('assert');
 const util = require('util');
+const binding = process.binding('util');
 const context = require('vm').runInNewContext;
 
 // isArray
@@ -132,3 +133,20 @@ util.print('test');
 util.puts('test');
 util.debug('test');
 util.error('test');
+
+{
+  // binding.isNativeError()
+  assert.strictEqual(binding.isNativeError(new Error()), true);
+  assert.strictEqual(binding.isNativeError(new TypeError()), true);
+  assert.strictEqual(binding.isNativeError(new SyntaxError()), true);
+  assert.strictEqual(binding.isNativeError(new (context('Error'))()), true);
+  assert.strictEqual(binding.isNativeError(new (context('TypeError'))()), true);
+  assert.strictEqual(binding.isNativeError(new (context('SyntaxError'))()),
+                     true);
+  assert.strictEqual(binding.isNativeError({}), false);
+  assert.strictEqual(binding.isNativeError({ name: 'Error', message: '' }),
+                     false);
+  assert.strictEqual(binding.isNativeError([]), false);
+  assert.strictEqual(binding.isNativeError(Object.create(Error.prototype)),
+                     false);
+}