Skip to content

Commit

Permalink
test: mark test-async-wrap-uncaughtexception as flaky
Browse files Browse the repository at this point in the history
`parallel/test-async-wrap-uncaughtexception.js` has become flaky.
At this time investigating the cause is still on going, but this issue
become has prevalent. In order to restore CI status to be relevant,
this marks the test as explicitly FLAKY.

PR-URL: #16694
Refs: #16210
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
refack committed Nov 3, 2017
1 parent b6df87e commit 75095d7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ prefix parallel
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
# https://github.com/nodejs/node/issues/16210
test-async-wrap-uncaughtexception

This comment has been minimized.

Copy link
@Trott

Trott Nov 3, 2017

Member

This is malformed and will not skip the test. It is missing the : PASS, FLAKY

PR to fix and quick land coming soon...

This comment has been minimized.

Copy link
@Trott

Trott Nov 3, 2017

Member

(And yeah, I approved this, so shame on me.)

This comment has been minimized.

Copy link
@Trott

Trott Nov 3, 2017

Member

Fixed in #16702

This comment has been minimized.

Copy link
@refack

refack Nov 3, 2017

Author Contributor

πŸ˜„ well it definitely solved the red CI issue


[$system==win32]

Expand Down

0 comments on commit 75095d7

Please sign in to comment.