deps: define V8_PRESERVE_MOST as no-op on Windows

It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools
nodejs · Nov 8, 2024 · 758aaee · 758aaee
1 parent 241e4a6
commit 758aaee
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/deps/v8/include/v8config.h b/deps/v8/include/v8config.h
@@ -581,11 +581,15 @@ path. Add it with -I<path> to the command line
 // functions.
 // Use like:
 //   V8_NOINLINE V8_PRESERVE_MOST void UnlikelyMethod();
+#if V8_OS_WIN
+# define V8_PRESERVE_MOST
+#else
 #if V8_HAS_ATTRIBUTE_PRESERVE_MOST
 # define V8_PRESERVE_MOST __attribute__((preserve_most))
 #else
 # define V8_PRESERVE_MOST /* NOT SUPPORTED */
 #endif
+#endif
 
 
 // A macro (V8_DEPRECATED) to mark classes or functions as deprecated.