Skip to content

Commit

Permalink
doc: use semantically appropriate tag for lines
Browse files Browse the repository at this point in the history
The HTML <hr> element represents a thematic break between
paragraph-level elements: for example, a change of scene in a story,
or a shift of topic within a section.
The HTML Content Division element (<div>) is the generic container
for flow content and does not inherently represent anything.

The <hr> tag semantically fits better the meaning of the line between
the lists.

Refs: https://html.spec.whatwg.org/multipage/grouping-content.html#the-hr-element

PR-URL: #34660
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
aduh95 authored and addaleax committed Sep 22, 2020
1 parent e23f7ee commit 75ea463
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions doc/api/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* [About this documentation](documentation.html)
* [Usage and example](synopsis.html)

<div class="line"></div>
<hr class="line"/>

* [Assertion testing](assert.html)
* [Async hooks](async_hooks.html)
Expand Down Expand Up @@ -61,6 +61,6 @@
* [Worker threads](worker_threads.html)
* [Zlib](zlib.html)

<div class="line"></div>
<hr class="line"/>

* [Code repository and issue tracker](https://github.com/nodejs/node)
2 changes: 1 addition & 1 deletion doc/api_assets/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ a code {

#column2 .line {
margin: 0 .5rem;
background-color: #707070;
border-color: #707070;
}

#column2 ul li:last-child {
Expand Down

0 comments on commit 75ea463

Please sign in to comment.