fs: fixup error message for invalid options.recursive

Use "options.recursive" instead of just "recursive" Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32472 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs · Mar 28, 2020 · 7d3791a · 7d3791a
1 parent a744dad
commit 7d3791a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -863,7 +863,7 @@ function mkdir(path, options, callback) {
   path = getValidatedPath(path);
 
   if (typeof recursive !== 'boolean')
-    throw new ERR_INVALID_ARG_TYPE('recursive', 'boolean', recursive);
+    throw new ERR_INVALID_ARG_TYPE('options.recursive', 'boolean', recursive);
 
   const req = new FSReqCallback();
   req.oncomplete = callback;
@@ -884,7 +884,7 @@ function mkdirSync(path, options) {
   }
   path = getValidatedPath(path);
   if (typeof recursive !== 'boolean')
-    throw new ERR_INVALID_ARG_TYPE('recursive', 'boolean', recursive);
+    throw new ERR_INVALID_ARG_TYPE('options.recursive', 'boolean', recursive);
 
   const ctx = { path };
   const result = binding.mkdir(pathModule.toNamespacedPath(path),

diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -345,7 +345,7 @@ async function mkdir(path, options) {
   } = options || {};
   path = getValidatedPath(path);
   if (typeof recursive !== 'boolean')
-    throw new ERR_INVALID_ARG_TYPE('recursive', 'boolean', recursive);
+    throw new ERR_INVALID_ARG_TYPE('options.recursive', 'boolean', recursive);
 
   return binding.mkdir(pathModule.toNamespacedPath(path),
                        parseFileMode(mode, 'mode', 0o777), recursive,

diff --git a/test/parallel/test-fs-mkdir.js b/test/parallel/test-fs-mkdir.js
@@ -229,7 +229,7 @@ if (common.isMainThread && (common.isLinux || common.isOSX)) {
       {
         code: 'ERR_INVALID_ARG_TYPE',
         name: 'TypeError',
-        message: 'The "recursive" argument must be of type boolean.' +
+        message: 'The "options.recursive" property must be of type boolean.' +
           received
       }
     );
@@ -238,7 +238,7 @@ if (common.isMainThread && (common.isLinux || common.isOSX)) {
       {
         code: 'ERR_INVALID_ARG_TYPE',
         name: 'TypeError',
-        message: 'The "recursive" argument must be of type boolean.' +
+        message: 'The "options.recursive" property must be of type boolean.' +
           received
       }
     );