Skip to content

Commit

Permalink
fixup! fixup! src: use v8::LocalVector instead of MaybeStackBuffer<Va…
Browse files Browse the repository at this point in the history
…lue>
  • Loading branch information
jasnell committed Sep 13, 2024
1 parent 301bdff commit 7da2d30
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
5 changes: 2 additions & 3 deletions src/node_sockaddr.cc
Original file line number Diff line number Diff line change
Expand Up @@ -510,9 +510,8 @@ MaybeLocal<Array> SocketAddressBlockList::ListRules(Environment* env) {
return Array::New(env->isolate(), rules.data(), rules.size());
}

bool SocketAddressBlockList::ListRules(
Environment* env,
LocalVector<Value>* rules) {
bool SocketAddressBlockList::ListRules(Environment* env,
LocalVector<Value>* rules) {
if (parent_ && !parent_->ListRules(env, rules))
return false;
for (const auto& rule : rules_) {
Expand Down
4 changes: 1 addition & 3 deletions src/node_sockaddr.h
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,7 @@ class SocketAddressBlockList : public MemoryRetainer {
SET_SELF_SIZE(SocketAddressBlockList)

private:
bool ListRules(
Environment* env,
v8::LocalVector<v8::Value>* vec);
bool ListRules(Environment* env, v8::LocalVector<v8::Value>* vec);

std::shared_ptr<SocketAddressBlockList> parent_;
std::list<std::unique_ptr<Rule>> rules_;
Expand Down

0 comments on commit 7da2d30

Please sign in to comment.