http: make idle http parser count configurable

nodejs · Jul 25, 2022 · 7ef749e · 7ef749e
1 parent 130bdf0
commit 7ef749e
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/doc/api/http.md b/doc/api/http.md
@@ -3633,6 +3633,16 @@ try {
 }
 ```
 
+## `http.setMaxIdleHTTPParsers`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+* {number}
+
+Set the maximum number of idle HTTP parsers. **Default:** `1000`.
+
 [RFC 8187]: https://www.rfc-editor.org/rfc/rfc8187.txt
 [`'checkContinue'`]: #event-checkcontinue
 [`'finish'`]: #event-finish

diff --git a/lib/http.js b/lib/http.js
@@ -27,9 +27,10 @@ const {
   ObjectDefineProperty,
 } = primordials;
 
+const { validateInteger } = require('internal/validators');
 const httpAgent = require('_http_agent');
 const { ClientRequest } = require('_http_client');
-const { methods } = require('_http_common');
+const { methods, parsers } = require('_http_common');
 const { IncomingMessage } = require('_http_incoming');
 const {
   validateHeaderName,
@@ -123,7 +124,11 @@ module.exports = {
   validateHeaderName,
   validateHeaderValue,
   get,
-  request
+  request,
+  setMaxIdleHTTPParsers(max) {
+    validateInteger(max, 'max');
+    parsers.max = max;
+  }
 };
 
 ObjectDefineProperty(module.exports, 'maxHeaderSize', {

diff --git a/test/parallel/test-http-set-max-idle-http-parser.js b/test/parallel/test-http-set-max-idle-http-parser.js
@@ -0,0 +1,8 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const httpCommon = require('_http_common');
+const http = require('http');
+assert.strictEqual(httpCommon.parsers.max !== 1, true);
+http.setMaxIdleHTTPParsers(1);
+assert.strictEqual(httpCommon.parsers.max, 1);