-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src: add initial shadow realm support
Add initial shadow realm support behind an off-by-default flag `--experimental-shadow-realm`.
- Loading branch information
1 parent
2691222
commit 8004257
Showing
7 changed files
with
65 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
#include "node_shadow_realm.h" | ||
|
||
namespace node { | ||
namespace shadow_realm { | ||
using v8::Context; | ||
using v8::Local; | ||
using v8::MaybeLocal; | ||
|
||
// static | ||
MaybeLocal<Context> HostCreateShadowRealmContextCallback( | ||
Local<Context> initiator_context) { | ||
return Context::New(initiator_context->GetIsolate()); | ||
} | ||
|
||
} // namespace shadow_realm | ||
} // namespace node |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
#ifndef SRC_NODE_SHADOW_REALM_H_ | ||
#define SRC_NODE_SHADOW_REALM_H_ | ||
|
||
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS | ||
|
||
#include "v8.h" | ||
|
||
namespace node { | ||
namespace shadow_realm { | ||
|
||
v8::MaybeLocal<v8::Context> HostCreateShadowRealmContextCallback( | ||
v8::Local<v8::Context> initiator_context); | ||
|
||
} // namespace shadow_realm | ||
} // namespace node | ||
|
||
#endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS | ||
|
||
#endif // SRC_NODE_SHADOW_REALM_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// Flags: --harmony-shadow-realm | ||
'use strict'; | ||
|
||
require('../common'); | ||
const assert = require('assert'); | ||
|
||
// Validates we can construct ShadowRealm successfully. | ||
const shadowRealm = new ShadowRealm(); | ||
|
||
const getter = shadowRealm.evaluate('globalThis.realmValue = "inner"; () => globalThis.realmValue;'); | ||
assert.strictEqual(getter(), 'inner'); | ||
assert.strictEqual('realmValue' in globalThis, false); |