readline: clean up event listener in onNewListener

Once the Readline interface is closed, the 'data' event listener should be removed. PR-URL: #13266 Ref: #9447 (comment) Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Jun 5, 2017 · 81ddeb9 · 81ddeb9
1 parent bccda4f
commit 81ddeb9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/readline.js b/lib/readline.js
@@ -1039,6 +1039,9 @@ function emitKeypressEvents(stream, iface) {
  } else {
  stream.on('newListener', onNewListener);
  }
+ if (iface) {
+ iface.once('close', () => { stream.removeListener('data', onData); });
+ }
 }
 
 /**

diff --git a/test/parallel/test-readline-set-raw-mode.js b/test/parallel/test-readline-set-raw-mode.js
@@ -74,6 +74,8 @@ assert(!rawModeCalled);
 assert(resumeCalled);
 assert(!pauseCalled);
 
+// One data listener for the keypress events.
+assert.strictEqual(stream.listeners('data').length, 1);
 
 // close() should call setRawMode(false)
 expectedRawMode = false;
@@ -86,5 +88,5 @@ assert(!resumeCalled);
 assert(pauseCalled);
 
 assert.deepStrictEqual(stream.listeners('keypress'), []);
-// one data listener for the keypress events.
-assert.strictEqual(stream.listeners('data').length, 1);
+// Data listener is removed once interface is closed.
+assert.strictEqual(stream.listeners('data').length, 0);