Skip to content

Commit

Permalink
doc: improve the workflow to test release binaries
Browse files Browse the repository at this point in the history
PR-URL: #45004
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
RafaelGSS authored and danielleadams committed Dec 28, 2022
1 parent b1f77e7 commit 838e01e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions doc/contributing/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -603,13 +603,14 @@ the build before moving forward. Use the following list as a baseline:
must be in the expected updated version)
* npm version (check it matches what we expect)
* Run the test suite against the built binaries (optional)
* Remember to use the proposal branch
* Run `make build-addons` before running the tests
* Remove `config.gypi` file

```console
./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node
```

<sup>There may be test issues if the branch used to test does not match the Node.js binary.</sup>

### 11. Tag and sign the release commit

Once you have produced builds that you're happy with, create a new tag. By
Expand Down

0 comments on commit 838e01e

Please sign in to comment.