path: fix toNamespacedPath on Windows

PR-URL: #52915 Fixes: #30224 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs · Jun 17, 2024 · 84da6a5 · 84da6a5
1 parent 26775c5
commit 84da6a5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/path.js b/lib/path.js
@@ -647,7 +647,7 @@ const win32 = {
       return `\\\\?\\${resolvedPath}`;
     }
 
-    return path;
+    return resolvedPath;
   },
 
   /**

diff --git a/test/parallel/test-path-makelong.js b/test/parallel/test-path-makelong.js
@@ -79,7 +79,8 @@ assert.strictEqual(path.win32.toNamespacedPath('\\\\foo\\bar'),
                    '\\\\?\\UNC\\foo\\bar\\');
 assert.strictEqual(path.win32.toNamespacedPath('//foo//bar'),
                    '\\\\?\\UNC\\foo\\bar\\');
-assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\foo'), '\\\\?\\foo');
+assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\foo'), '\\\\?\\foo\\');
+assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\c:\\Windows/System'), '\\\\?\\c:\\Windows\\System');
 assert.strictEqual(path.win32.toNamespacedPath(null), null);
 assert.strictEqual(path.win32.toNamespacedPath(true), true);
 assert.strictEqual(path.win32.toNamespacedPath(1), 1);
-Original file line number
+Diff line change
@@ Expand Up / @@ -647,7 +647,7 @@ const win32 = { @@
           return `\\\\?\\${resolvedPath}`;
         }
-        return path;
+        return resolvedPath;
       },
       /**
@@ Expand Down @@