bootstrap: add exception handling for profiler bootstrap

Add exception handling for the case when profile is
not bootstrapped when coverage is enabled.

Fixes: #29542

PR-URL: #29552
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

lib/internal/bootstrap/pre_execution.js

@@ -120,8 +120,16 @@ function setupCoverageHooks(dir) {
  const { resolve } = require('path');
  const coverageDirectory = resolve(cwd, dir);
  const { sourceMapCacheToObject } = require('internal/source_map');
- internalBinding('profiler').setCoverageDirectory(coverageDirectory);
- internalBinding('profiler').setSourceMapCacheGetter(sourceMapCacheToObject);
+
+ if (process.features.inspector) {
+ internalBinding('profiler').setCoverageDirectory(coverageDirectory);
+ internalBinding('profiler').setSourceMapCacheGetter(sourceMapCacheToObject);
+ } else {
+ process.emitWarning('The inspector is disabled, ' +
+ 'coverage could not be collected',
+ 'Warning');
+ return '';
+ }
  return coverageDirectory;
 }
 

test/common/index.js

@@ -651,6 +651,12 @@ function skipIfInspectorDisabled() {
  }
 }
 
+function skipIfInspectorEnabled() {
+ if (process.features.inspector) {
+ skip('V8 inspector is enabled');
+ }
+}
+
 function skipIfReportDisabled() {
  if (!process.config.variables.node_report) {
  skip('Diagnostic reporting is disabled');
@@ -783,6 +789,7 @@ module.exports = {
  skipIf32Bits,
  skipIfEslintMissing,
  skipIfInspectorDisabled,
+ skipIfInspectorEnabled,
  skipIfReportDisabled,
  skipIfWorker,
 

test/parallel/test-coverage-with-inspector-disabled.js

@@ -0,0 +1,24 @@
+'use strict';
+
+const common = require('../common');
+common.skipIfInspectorEnabled();
+
+const fixtures = require('../common/fixtures');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const env = { ...process.env, NODE_V8_COVERAGE: '/foo/bar' };
+const childPath = fixtures.path('v8-coverage/subprocess');
+const { status, stderr } = spawnSync(
+ process.execPath,
+ [childPath],
+ { env }
+);
+
+const warningMessage = 'The inspector is disabled, ' +
+ 'coverage could not be collected';
+
+assert.strictEqual(status, 0);
+assert.strictEqual(
+ stderr.toString().includes(`Warning: ${warningMessage}`),
+ true
+);