tools: fix lint V8

nodejs · May 26, 2023 · 86e0c9d · 86e0c9d
1 parent 7f19d30
commit 86e0c9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/doc/contributing/maintaining/maintaining-dependencies.md b/doc/contributing/maintaining/maintaining-dependencies.md
@@ -30,7 +30,7 @@ This a list of all the dependencies:
 * [simdutf 3.2.9][]
 * [undici 5.22.1][]
 * [uvwasi 0.0.16][]
-* [v8 11.3.244.8][]
+* [V8 11.3.244.8][]
 * [zlib 1.2.13][]
 
 Any code which meets one or more of these conditions should
@@ -305,7 +305,7 @@ implement WASI calls.
 Under the hood, uvwasi leverages libuv where possible for maximum portability.
 See [maintaining-web-assembly][] for more informations.
 
-### v8 11.3.244.8
+### V8 11.3.244.8
 
 [V8](https://chromium.googlesource.com/v8/v8.git/) is Google's open source
 high-performance JavaScript and WebAssembly engine, written in C++.

diff --git a/tools/dep_updaters/update-v8-patch.sh b/tools/dep_updaters/update-v8-patch.sh
@@ -26,8 +26,10 @@ CURRENT_PATCH_VERSION=$(grep "#define V8_PATCH_LEVEL" "$DEPS_DIR/v8/include/v8-v
 NEW_VERSION="$CURRENT_MAJOR_VERSION.$CURRENT_MINOR_VERSION.$CURRENT_BUILD_VERSION.$CURRENT_PATCH_VERSION"
 
 
-# Update the version number
+# Update the version number. We have to call it twice because V8 is written
+# both in lowercase and uppdercase
 update_dependency_version "v8" "$NEW_VERSION"
+update_dependency_version "V8" "$NEW_VERSION"
 
 echo "All done!"
 echo ""