test_runner: fixes comments

Adds missing returns. Removes unnecessary regex replace in lcov reporter test
nodejs · Oct 3, 2023 · 88bc90c · 88bc90c
1 parent a2493a6
commit 88bc90c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/lib/internal/test_runner/reporter/lcov.js b/lib/internal/test_runner/reporter/lcov.js
@@ -95,11 +95,11 @@ class LcovReporter extends Transform {
           lcov += 'end_of_record\n';
         }
       } catch (error) {
-        callback(error);
+        return callback(error);
       }
       return callback(null, lcov);
     }
-    callback(null);
+    return callback(null);
   }
 }
 

diff --git a/test/fixtures/test-runner/output/lcov_reporter.js b/test/fixtures/test-runner/output/lcov_reporter.js
@@ -3,9 +3,5 @@ require('../../../common');
 const fixtures = require('../../../common/fixtures');
 const spawn = require('node:child_process').spawn;
 
-const child = spawn(process.execPath,
-                    ['--no-warnings', '--experimental-test-coverage', '--test-reporter', 'lcov', fixtures.path('test-runner/output/output.js')],
-                    { stdio: 'pipe' });
-// eslint-disable-next-line no-control-regex
-child.stdout.on('data', (d) => process.stdout.write(d.toString().replace(/[^\x00-\x7F]/g, '').replace(/\u001b\[\d+m/g, '')));
-child.stderr.pipe(process.stderr);
+spawn(process.execPath,
+      ['--no-warnings', '--experimental-test-coverage', '--test-reporter', 'lcov', fixtures.path('test-runner/output/output.js')], { stdio: 'inherit' });