Skip to content

Commit

Permalink
build: remove warning cflags from V8 build
Browse files Browse the repository at this point in the history
  • Loading branch information
targos committed May 7, 2024
1 parent 791b8ff commit 8aa2de8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
1 change: 0 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
'configuring_node%': 0,
'asan%': 0,
'ubsan%': 0,
'werror': '', # Turn off -Werror in V8 build.
'visibility%': 'hidden', # V8's visibility setting
'target_arch%': 'ia32', # set v8's target architecture
'host_arch%': 'ia32', # set v8's host architecture
Expand Down
17 changes: 2 additions & 15 deletions tools/v8_gypfiles/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
'v8_toolset_for_shell%': 'target',

'host_os%': '<(OS)',
'werror%': '-Werror',
# For a shared library build, results in "libv8-<(soname_version).so".
'soname_version%': '',

Expand Down Expand Up @@ -133,23 +132,14 @@
'<(V8_ROOT)',
'<(V8_ROOT)/include',
],
'cflags!': ['-Wall', '-Wextra'],
'conditions': [
['clang==1', {
'cflags': [ '-Werror', '-Wno-unknown-pragmas' ],
},{
'cflags!': [ '-Wall', '-Wextra' ],
['clang==0', {
'cflags': [
'-Wno-return-type',
# On by default in Clang and V8 requires it at least for arm64.
'-flax-vector-conversions',
],
}],
['clang==1 or OS!="win"', {
'cflags': [ '-Wno-invalid-offsetof' ],
'xcode_settings': {
'WARNING_CFLAGS': ['-Wno-invalid-offsetof']
},
}],
['v8_target_arch=="arm"', {
'defines': [
'V8_TARGET_ARCH_ARM',
Expand Down Expand Up @@ -434,9 +424,6 @@
['_toolset=="target"', {
'conditions': [
['v8_target_arch==target_arch', {
'cflags': [
'-Wno-error=array-bounds', # Workaround https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56273
],
'conditions': [
['v8_target_arch=="mips64el"', {
'cflags': ['-EL'],
Expand Down

0 comments on commit 8aa2de8

Please sign in to comment.