test: remove common.PORT from parallel tests

`common.PORT` should not be used in parallel tests because another test may experience a collision with `common.PORT` when using port 0 to get an open port. This has been observed to result in test failures in CI.
nodejs · Dec 4, 2017 · 9062864 · 9062864
1 parent e1054ab
commit 9062864
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/test/async-hooks/test-graph.tcp.js b/test/async-hooks/test-graph.tcp.js
@@ -15,7 +15,7 @@ const server = net
   .createServer(common.mustCall(onconnection))
   .on('listening', common.mustCall(onlistening));
 
-server.listen(common.PORT);
+server.listen(0);
 
 net.connect({ port: server.address().port, host: '::1' },
             common.mustCall(onconnected));

diff --git a/test/async-hooks/test-graph.tls-write.js b/test/async-hooks/test-graph.tls-write.js
@@ -25,14 +25,14 @@ const server = tls
   })
   .on('listening', common.mustCall(onlistening))
   .on('secureConnection', common.mustCall(onsecureConnection))
-  .listen(common.PORT);
+  .listen(0);
 
 function onlistening() {
   //
   // Creating client and connecting it to server
   //
   tls
-    .connect(common.PORT, { rejectUnauthorized: false })
+    .connect(server.address().port, { rejectUnauthorized: false })
     .on('secureConnect', common.mustCall(onsecureConnect));
 }
 

diff --git a/test/async-hooks/test-tcpwrap.js b/test/async-hooks/test-tcpwrap.js
@@ -24,7 +24,7 @@ const server = net
 
 // Calling server.listen creates a TCPWRAP synchronously
 {
-  server.listen(common.PORT);
+  server.listen(0);
   const tcpsservers = hooks.activitiesOfTypes('TCPSERVERWRAP');
   const tcpconnects = hooks.activitiesOfTypes('TCPCONNECTWRAP');
   assert.strictEqual(tcpsservers.length, 1);

diff --git a/test/async-hooks/test-writewrap.js b/test/async-hooks/test-writewrap.js
@@ -23,7 +23,7 @@ const server = tls
   })
   .on('listening', common.mustCall(onlistening))
   .on('secureConnection', common.mustCall(onsecureConnection))
-  .listen(common.PORT);
+  .listen(0);
 
 assert.strictEqual(hooks.activitiesOfTypes('WRITEWRAP').length, 0);
 
@@ -33,7 +33,7 @@ function onlistening() {
   // Creating client and connecting it to server
   //
   tls
-    .connect(common.PORT, { rejectUnauthorized: false })
+    .connect(server.address().port, { rejectUnauthorized: false })
     .on('secureConnect', common.mustCall(onsecureConnect));
 
   assert.strictEqual(hooks.activitiesOfTypes('WRITEWRAP').length, 0);

diff --git a/test/parallel/test-net-connect-immediate-finish.js b/test/parallel/test-net-connect-immediate-finish.js
@@ -38,9 +38,9 @@ const {
 
 const client = net.connect({
   host: addresses.INVALID_HOST,
-  port: common.PORT,
+  port: 80, // port number doesn't matter because host name is invalid
   lookup: common.mustCall(errorLookupMock())
-});
+}, common.mustNotCall());
 
 client.once('error', common.mustCall((err) => {
   assert(err);

diff --git a/test/parallel/test-tls-connect.js → test/sequential/test-tls-connect.js b/test/parallel/test-tls-connect.js → test/sequential/test-tls-connect.js
diff --git a/test/parallel/test-tls-lookup.js → test/sequential/test-tls-lookup.js b/test/parallel/test-tls-lookup.js → test/sequential/test-tls-lookup.js