Skip to content

Commit

Permalink
test: refactor test-http-pipeline-flood
Browse files Browse the repository at this point in the history
This extends fixes for test-https-pipeline-flood to hopefully fully
eliminate its flakiness on Windows in our continuous integration
process.

PR-URL: #3636
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
Trott authored and Myles Borins committed Nov 17, 2015
1 parent f5dde5e commit 9294523
Showing 1 changed file with 24 additions and 32 deletions.
56 changes: 24 additions & 32 deletions test/sequential/test-http-pipeline-flood.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

// Here we are testing the HTTP server module's flood prevention mechanism.
// When writeable.write returns false (ie the underlying send() indicated the
Expand All @@ -18,29 +18,31 @@ switch (process.argv[2]) {
case 'child':
return child();
default:
throw new Error('wtf');
throw new Error(`Unexpected value: ${process.argv[2]}`);
}

function parent() {
var http = require('http');
var bigResponse = new Buffer(10240).fill('x');
const http = require('http');
const bigResponse = new Buffer(10240).fill('x');
var gotTimeout = false;
var childClosed = false;
var requests = 0;
var connections = 0;
var backloggedReqs = 0;

var server = http.createServer(function(req, res) {
const server = http.createServer(function(req, res) {
requests++;
res.setHeader('content-length', bigResponse.length);
if (!res.write(bigResponse)) {
if (backloggedReqs == 0) {
if (backloggedReqs === 0) {
// Once the native buffer fills (ie write() returns false), the flood
// prevention should kick in.
// This means the stream should emit no more 'data' events. However we
// may still be asked to process more requests if they were read before
// mechanism activated.
req.socket.on('data', function() { assert(false); });
// the flood-prevention mechanism activated.
setImmediate(() => {
req.socket.on('data', () => common.fail('Unexpected data received'));
});
}
backloggedReqs++;
}
Expand All @@ -51,56 +53,46 @@ function parent() {
connections++;
});

server.setTimeout(200, function(conn) {
gotTimeout = true;
});

server.listen(common.PORT, function() {
var spawn = require('child_process').spawn;
var args = [__filename, 'child'];
var child = spawn(process.execPath, args, { stdio: 'inherit' });
child.on('close', function(code) {
assert(!code);
const spawn = require('child_process').spawn;
const args = [__filename, 'child'];
const child = spawn(process.execPath, args, { stdio: 'inherit' });
child.on('close', function() {
childClosed = true;
server.close();
});

server.setTimeout(common.platformTimeout(200), function(conn) {
gotTimeout = true;
child.kill();
});
});

process.on('exit', function() {
assert(gotTimeout);
assert(childClosed);
assert.equal(connections, 1);
// The number of requests we end up processing before the outgoing
// connection backs up and requires a drain is implementation-dependent.
console.log('server got %d requests', requests);
console.log('server sent %d backlogged requests', backloggedReqs);

console.log('ok');
});
}

function child() {
var net = require('net');
const net = require('net');

var conn = net.connect({ port: common.PORT });
const conn = net.connect({ port: common.PORT });

var req = 'GET / HTTP/1.1\r\nHost: localhost:' +
common.PORT + '\r\nAccept: */*\r\n\r\n';

req = new Array(10241).join(req);

conn.on('connect', function() {
//kill child after 1s of flooding
setTimeout(function() { conn.destroy(); }, 1000);
// Terminate child after flooding.
setTimeout(function() { conn.destroy(); }, common.platformTimeout(1000));
write();
});

conn.on('drain', write);

process.on('exit', function() {
console.log('ok - child');
});

function write() {
while (false !== conn.write(req, 'ascii'));
}
Expand Down

0 comments on commit 9294523

Please sign in to comment.