fs: Swallow error

nodejs · Dec 19, 2018 · 930c8d4 · 930c8d4
1 parent e657b86
commit 930c8d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/lib/internal/fs/streams.js b/lib/internal/fs/streams.js
@@ -134,11 +134,8 @@ ReadStream.prototype.open = function() {
     this.fd = fd;
 
     if (this.destroyed) {
-      closeFsStream(this, (er) => {
-        if (er) {
-          this.emit('error', er);
-        }
-      });
+      // swallow the error to prevent error from emitting after close.
+      closeFsStream(this, () => {});
       return;
     }
 
@@ -307,11 +304,7 @@ WriteStream.prototype.open = function() {
     this.fd = fd;
 
     if (this.destroyed) {
-      closeFsStream(this, (er) => {
-        if (er) {
-          this.emit('error', er);
-        }
-      });
+      closeFsStream(this, () => {});
       return;
     }
 

diff --git a/test/parallel/test-fs-stream-no-events-after-destroy.js b/test/parallel/test-fs-stream-no-events-after-destroy.js
@@ -12,10 +12,7 @@ const test = (stream) => {
   stream.on('open', common.mustNotCall());
   stream.on('ready', common.mustNotCall());
   stream.on('close', common.mustCall());
-  stream.on('error', common.mustCall((er) => {
-    assert.strictEqual(err, er);
-    assert.strictEqual(stream.closed, false);
-  }));
+  stream.on('error', common.mustNotCall());
 }
 
 test(fs.createReadStream(__filename));