Skip to content

Commit

Permalink
src: remove base64 from process.versions
Browse files Browse the repository at this point in the history
The `base64` dependency was previously removed along with the update
script (`tools/dep_updaters/update-base64.sh`) but the generated header,
`src/base64_version.h` was left behind and `process.versions` was still
listing the last version of `base64` that was included in Node.js before
it was removed

Refs: #52714
PR-URL: #53442
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
  • Loading branch information
richardlau authored Jun 15, 2024
1 parent d57894d commit 9351425
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 11 deletions.
6 changes: 0 additions & 6 deletions src/base64_version.h

This file was deleted.

2 changes: 0 additions & 2 deletions src/node_metadata.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#include "acorn_version.h"
#include "ada.h"
#include "ares.h"
#include "base64_version.h"
#include "brotli/encode.h"
#include "cjs_module_lexer_version.h"
#include "llhttp.h"
Expand Down Expand Up @@ -113,7 +112,6 @@ Metadata::Versions::Versions() {

acorn = ACORN_VERSION;
cjs_module_lexer = CJS_MODULE_LEXER_VERSION;
base64 = BASE64_VERSION;
uvwasi = UVWASI_VERSION_STRING;

#if HAVE_OPENSSL
Expand Down
3 changes: 1 addition & 2 deletions src/node_metadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ namespace node {
V(sqlite) \
V(ada) \
NODE_VERSIONS_KEY_UNDICI(V) \
V(cjs_module_lexer) \
V(base64)
V(cjs_module_lexer)

#if HAVE_OPENSSL
#define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl)
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-process-versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ const expected_keys = [
'sqlite',
'ada',
'cjs_module_lexer',
'base64',
];

const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js');
Expand Down

0 comments on commit 9351425

Please sign in to comment.