http: make idle http parser count configurable

nodejs · Jul 27, 2022 · 95420be · 95420be
1 parent 10ee408
commit 95420be
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 2 deletions.
diff --git a/doc/api/http.md b/doc/api/http.md
@@ -3633,6 +3633,16 @@ try {
 }
 ```
 
+## `http.setMaxIdleHTTPParsers`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+* {number}
+
+Set the maximum number of idle HTTP parsers. **Default:** `1000`.
+
 [RFC 8187]: https://www.rfc-editor.org/rfc/rfc8187.txt
 [`'checkContinue'`]: #event-checkcontinue
 [`'finish'`]: #event-finish

diff --git a/lib/http.js b/lib/http.js
@@ -27,9 +27,10 @@ const {
   ObjectDefineProperty,
 } = primordials;
 
+const { validateInteger } = require('internal/validators');
 const httpAgent = require('_http_agent');
 const { ClientRequest } = require('_http_client');
-const { methods } = require('_http_common');
+const { methods, parsers } = require('_http_common');
 const { IncomingMessage } = require('_http_incoming');
 const {
   validateHeaderName,
@@ -123,7 +124,11 @@ module.exports = {
   validateHeaderName,
   validateHeaderValue,
   get,
-  request
+  request,
+  setMaxIdleHTTPParsers(max) {
+    validateInteger(max, 'max', 1);
+    parsers.max = max;
+  }
 };
 
 ObjectDefineProperty(module.exports, 'maxHeaderSize', {

diff --git a/test/parallel/test-http-set-max-idle-http-parser.js b/test/parallel/test-http-set-max-idle-http-parser.js
@@ -0,0 +1,19 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const httpCommon = require('_http_common');
+const http = require('http');
+
+[Symbol(), {}, [], () => {}, 1n, true, '1', null, undefined].forEach((value) => {
+  assert.throws(() => http.setMaxIdleHTTPParsers(value), { code: 'ERR_INVALID_ARG_TYPE' });
+});
+
+[-1, -Infinity, NaN, 0, 1.1].forEach((value) => {
+  assert.throws(() => http.setMaxIdleHTTPParsers(value), { code: 'ERR_OUT_OF_RANGE' });
+});
+
+[1, Number.MAX_SAFE_INTEGER].forEach((value) => {
+  assert.notStrictEqual(httpCommon.parsers.max, value);
+  http.setMaxIdleHTTPParsers(value);
+  assert.strictEqual(httpCommon.parsers.max, value);
+});