-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http: set async_id_symbol to any socket set
OutgoingMessage needs a async-hooks enabled socket to work, but we support also basic streams. This PR init the async-hooks bits for the passed stream if it is needed. PR-URL: #14389 Fixes: #14386 Fixes: #14381
- Loading branch information
Showing
3 changed files
with
75 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const { OutgoingMessage } = require('http'); | ||
const { Writable } = require('stream'); | ||
const assert = require('assert'); | ||
|
||
// check that OutgoingMessage can be used without a proper Socket | ||
// Fixes: https://github.com/nodejs/node/issues/14386 | ||
// Fixes: https://github.com/nodejs/node/issues/14381 | ||
|
||
class Response extends OutgoingMessage { | ||
constructor() { | ||
super({ method: 'GET', httpVersionMajor: 1, httpVersionMinor: 1 }); | ||
} | ||
|
||
_implicitHeader() {} | ||
} | ||
|
||
const res = new Response(); | ||
const ws = new Writable({ | ||
write: common.mustCall((chunk, encoding, callback) => { | ||
assert(chunk.toString().match(/hello world/)); | ||
setImmediate(callback); | ||
}) | ||
}); | ||
|
||
res.socket = ws; | ||
ws._httpMessage = res; | ||
res.connection = ws; | ||
|
||
res.end('hello world'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const { ServerResponse } = require('http'); | ||
const { Writable } = require('stream'); | ||
const assert = require('assert'); | ||
|
||
// check that ServerResponse can be used without a proper Socket | ||
// Fixes: https://github.com/nodejs/node/issues/14386 | ||
// Fixes: https://github.com/nodejs/node/issues/14381 | ||
|
||
const res = new ServerResponse({ | ||
method: 'GET', | ||
httpVersionMajor: 1, | ||
httpVersionMinor: 1 | ||
}); | ||
|
||
const ws = new Writable({ | ||
write: common.mustCall((chunk, encoding, callback) => { | ||
assert(chunk.toString().match(/hello world/)); | ||
setImmediate(callback); | ||
}) | ||
}); | ||
|
||
res.assignSocket(ws); | ||
|
||
res.end('hello world'); |