Skip to content

Commit

Permalink
http: name anonymous functions in _http_server
Browse files Browse the repository at this point in the history
Refs: #8913
PR-URL: #9055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
maasencioh authored and jasnell committed Oct 18, 2016
1 parent 86c4a5c commit 9b178ef
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions lib/_http_server.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ function ServerResponse(req) {
}
util.inherits(ServerResponse, OutgoingMessage);

ServerResponse.prototype._finish = function() {
ServerResponse.prototype._finish = function _finish() {
DTRACE_HTTP_SERVER_RESPONSE(this.connection);
LTTNG_HTTP_SERVER_RESPONSE(this.connection);
COUNTER_HTTP_SERVER_RESPONSE();
Expand Down Expand Up @@ -131,7 +131,7 @@ function onServerResponseClose() {
if (this._httpMessage) this._httpMessage.emit('close');
}

ServerResponse.prototype.assignSocket = function(socket) {
ServerResponse.prototype.assignSocket = function assignSocket(socket) {
assert(!socket._httpMessage);
socket._httpMessage = this;
socket.on('close', onServerResponseClose);
Expand All @@ -141,23 +141,24 @@ ServerResponse.prototype.assignSocket = function(socket) {
this._flush();
};

ServerResponse.prototype.detachSocket = function(socket) {
ServerResponse.prototype.detachSocket = function detachSocket(socket) {
assert(socket._httpMessage === this);
socket.removeListener('close', onServerResponseClose);
socket._httpMessage = null;
this.socket = this.connection = null;
};

ServerResponse.prototype.writeContinue = function(cb) {
ServerResponse.prototype.writeContinue = function writeContinue(cb) {
this._writeRaw('HTTP/1.1 100 Continue' + CRLF + CRLF, 'ascii', cb);
this._sent100 = true;
};

ServerResponse.prototype._implicitHeader = function() {
ServerResponse.prototype._implicitHeader = function _implicitHeader() {
this.writeHead(this.statusCode);
};

ServerResponse.prototype.writeHead = function(statusCode, reason, obj) {
ServerResponse.prototype.writeHead = writeHead;
function writeHead(statusCode, reason, obj) {
var headers;

if (typeof reason === 'string') {
Expand Down Expand Up @@ -219,9 +220,9 @@ ServerResponse.prototype.writeHead = function(statusCode, reason, obj) {
}

this._storeHeader(statusLine, headers);
};
}

ServerResponse.prototype.writeHeader = function() {
ServerResponse.prototype.writeHeader = function writeHeader() {
this.writeHead.apply(this, arguments);
};

Expand Down Expand Up @@ -250,7 +251,7 @@ function Server(requestListener) {
util.inherits(Server, net.Server);


Server.prototype.setTimeout = function(msecs, callback) {
Server.prototype.setTimeout = function setTimeout(msecs, callback) {
this.timeout = msecs;
if (callback)
this.on('timeout', callback);
Expand Down

0 comments on commit 9b178ef

Please sign in to comment.