src: print backtrace on abort/unreachable code

Print a C backtrace on fatal errors to make it easier to debug issues.
nodejs · May 13, 2016 · 9c63535 · 9c63535
1 parent cd737bb
commit 9c63535
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -2383,7 +2383,6 @@ static void OnFatalError(const char* location, const char* message) {
   } else {
     PrintErrorString("FATAL ERROR: %s\n", message);
   }
-  DumpBacktrace(stderr);
   fflush(stderr);
   ABORT();
 }

diff --git a/src/util.h b/src/util.h
@@ -6,6 +6,7 @@
 #include <assert.h>
 #include <signal.h>
 #include <stddef.h>
+#include <stdio.h>
 #include <stdlib.h>
 
 namespace node {
@@ -21,9 +22,21 @@ namespace node {
 
 // Windows 8+ does not like abort() in Release mode
 #ifdef _WIN32
-#define ABORT() raise(SIGABRT)
+#define ABORT_NO_BACKTRACE() raise(SIGABRT)
 #else
-#define ABORT() abort()
+#define ABORT_NO_BACKTRACE() abort()
+#endif
+
+// This macro is also used indirectly by some of the addons in test/addons.
+#ifdef NODE_WANT_INTERNALS
+# define ABORT()                                                              \
+  do {                                                                        \
+    node::DumpBacktrace(stderr);                                              \
+    fflush(stderr);                                                           \
+    ABORT_NO_BACKTRACE();                                                     \
+  } while (0)
+#else
+# define ABORT() ABORT_NO_BACKTRACE()
 #endif
 
 #if defined(NDEBUG)