src: keep PipeWrap::Open function consistent with TCPWrap

PR-URL: #46064 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs · Jan 6, 2023 · 9e86c49 · 9e86c49
1 parent 4788c0d
commit 9e86c49
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/pipe_wrap.cc b/src/pipe_wrap.cc
@@ -217,10 +217,9 @@ void PipeWrap::Open(const FunctionCallbackInfo<Value>& args) {
   if (!args[0]->Int32Value(env->context()).To(&fd)) return;
 
   int err = uv_pipe_open(&wrap->handle_, fd);
-  wrap->set_fd(fd);
+  if (err == 0) wrap->set_fd(fd);
 
-  if (err != 0)
-    env->ThrowUVException(err, "uv_pipe_open");
+  args.GetReturnValue().Set(err);
 }