Skip to content

Commit

Permalink
test: swap the order arguments are passed to
Browse files Browse the repository at this point in the history
Documentation for assertions rule actual values should be passed first
followed by the expected value. This commit update the assertions the
changed file contains to comply to that rule. Changes also label the
assertions.
  • Loading branch information
n370 committed Oct 13, 2018
1 parent 401dac3 commit 9f8f1a4
Showing 1 changed file with 16 additions and 3 deletions.
19 changes: 16 additions & 3 deletions test/pummel/test-keep-alive.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,20 @@ server.listen(common.PORT, () => {
});

process.on('exit', function() {
assert.strictEqual(true, normalReqSec > 50);
assert.strictEqual(true, keepAliveReqSec > 50);
assert.strictEqual(true, normalReqSec < keepAliveReqSec);
assert.strictEqual(
normalReqSec > 50,
true,
`normalReqSec should be greater than 50, but got ${normalReqSec}`
);
assert.strictEqual(
keepAliveReqSec > 50,
true,
`keepAliveReqSec should be greater than 50, but got ${keepAliveReqSec}`
);
assert.strictEqual(
normalReqSec < keepAliveReqSec,
true,
'normalReqSec should be less than keepAliveReqSec, ' +
`but ${normalReqSec} is greater than ${keepAliveReqSec}`
);
});

0 comments on commit 9f8f1a4

Please sign in to comment.