Skip to content

Commit

Permalink
deps: do not add extra newline in log file
Browse files Browse the repository at this point in the history
The commit in v0.10 (431eb17) that
backported the original change
(https://codereview.chromium.org/806143002) did add an extra newline
because the logging facilities in v0.10's V8 do not add one.

When merging this commit in v0.12, V8's logging facilities now
automatically add the newline character, and the debug builds assert if
one is already present.
  • Loading branch information
Julien Gilli committed Feb 17, 2015
1 parent 2b095bb commit a103712
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deps/v8/src/log-utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void Log::Initialize(const char* log_file_name) {

if (output_handle_ != NULL) {
Log::MessageBuilder msg(this);
msg.Append("v8-version,%d,%d,%d,%d,%d\n", Version::GetMajor(),
msg.Append("v8-version,%d,%d,%d,%d,%d", Version::GetMajor(),
Version::GetMinor(), Version::GetBuild(), Version::GetPatch(),
Version::IsCandidate());
msg.WriteToLogFile();
Expand Down

0 comments on commit a103712

Please sign in to comment.