Skip to content

Commit

Permalink
test: improvements in test fixtures symlinked
Browse files Browse the repository at this point in the history
- using strictEqual instead equal
- common dependency should be the first one
- using path.join instead relative path

PR-URL: #10182
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
  • Loading branch information
edsadr authored and MylesBorins committed Jan 22, 2017
1 parent 13a75dc commit a108324
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions test/fixtures/module-require-symlink/symlinked.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
'use strict';
const assert = require('assert');
const common = require('../../common');
const assert = require('assert');
const foo = require('./foo');
const path = require('path');

const linkScriptTarget = path.join(common.fixturesDir,
'/module-require-symlink/symlinked.js');
'module-require-symlink', 'symlinked.js');

var foo = require('./foo');
assert.equal(foo.dep1.bar.version, 'CORRECT_VERSION');
assert.equal(foo.dep2.bar.version, 'CORRECT_VERSION');
assert.equal(__filename, linkScriptTarget);
assert.strictEqual(foo.dep1.bar.version, 'CORRECT_VERSION');
assert.strictEqual(foo.dep2.bar.version, 'CORRECT_VERSION');
assert.strictEqual(__filename, linkScriptTarget);
assert(__filename in require.cache);

0 comments on commit a108324

Please sign in to comment.