test_runner: require --enable-source-maps for source map coverage

nodejs · Sep 21, 2024 · a478463 · a478463
1 parent 8b8fc53
commit a478463
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/lib/internal/test_runner/coverage.js b/lib/internal/test_runner/coverage.js
@@ -30,6 +30,7 @@ const { tmpdir } = require('os');
 const { join, resolve, relative, matchesGlob } = require('path');
 const { fileURLToPath } = require('internal/url');
 const { kMappings, SourceMap } = require('internal/source_map/source_map');
+const { getOptionValue } = require('internal/options');
 const kCoverageFileRegex = /^coverage-(\d+)-(\d{13})-(\d+)\.json$/;
 const kIgnoreRegex = /\/\* node:coverage ignore next (?<count>\d+ )?\*\//;
 const kLineEndingRegex = /\r?\n$/u;
@@ -335,7 +336,7 @@ class TestCoverage {
  mapCoverageWithSourceMap(coverage) {
  const { result } = coverage;
  const sourceMapCache = coverage['source-map-cache'];
- if (!sourceMapCache) {
+ if (!getOptionValue('--enable-source-maps') || !sourceMapCache) {
  return result;
  }
  const newResult = new SafeMap();

diff --git a/test/parallel/test-runner-coverage.js b/test/parallel/test-runner-coverage.js
@@ -311,7 +311,10 @@ test('coverage with source maps', skipIfNoInspector, () => {
 
  const fixture = fixtures.path('test-runner', 'coverage');
  const args = [
- '--test', '--experimental-test-coverage', '--test-reporter', 'tap',
+ '--enable-source-maps',
+ '--test',
+ '--experimental-test-coverage',
+ '--test-reporter', 'tap',
  ];
  const result = spawnSync(process.execPath, args, { cwd: fixture });
 
@@ -489,7 +492,10 @@ test('coverage with included and excluded files', skipIfNoInspector, () => {
 test('properly accounts for line endings in source maps', skipIfNoInspector, () => {
  const fixture = fixtures.path('test-runner', 'source-map-line-lengths', 'index.js');
  const args = [
- '--test', '--experimental-test-coverage', '--test-reporter', 'tap',
+ '--enable-source-maps',
+ '--test',
+ '--experimental-test-coverage',
+ '--test-reporter', 'tap',
  fixture,
  ];
  const report = [