Skip to content

Commit

Permalink
test: add Debugger.setInstrumentationBreakpoint known issue
Browse files Browse the repository at this point in the history
PR-URL: #31137
Refs: #31138
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
ulitink authored and marco-ippolito committed Jun 17, 2024
1 parent 808e5c7 commit a536d0d
Show file tree
Hide file tree
Showing 4 changed files with 58 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,8 @@ function printSkipMessage(msg) {

function skip(msg) {
printSkipMessage(msg);
process.exit(0);
// In known_issues test, skipping should produce a non-zero exit code.
process.exit(require.main?.filename.startsWith(path.resolve(__dirname, '../known_issues/')) ? 1 : 0);
}

// Returns true if the exit code "exitCode" and/or signal name "signal"
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/inspector-instrumentation-breakpoint/dep.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
console.log('dep loaded');
1 change: 1 addition & 0 deletions test/fixtures/inspector-instrumentation-breakpoint/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
require('./dep');
54 changes: 54 additions & 0 deletions test/known_issues/test-inspector-instrumentation-breakpoint.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
// This test validates inspector's Debugger.setInstrumentationBreakpoint method.
// Refs: https://github.com/nodejs/node/issues/31138

'use strict';
const common = require('../common');

common.skipIfInspectorDisabled();

const assert = require('assert');
const { resolve: UrlResolve } = require('url');
const fixtures = require('../common/fixtures');
const { NodeInstance } = require('../common/inspector-helper.js');

async function testBreakpointBeforeScriptExecution(session) {
console.log('[test]',
'Verifying debugger stops on start of each script ' +
'(Debugger.setInstrumentationBreakpoint with beforeScriptExecution)');
const commands = [
{ 'method': 'Runtime.enable' },
{ 'method': 'Debugger.enable' },
{ 'method': 'Debugger.setInstrumentationBreakpoint',
'params': { 'instrumentation': 'beforeScriptExecution' } },
{ 'method': 'Runtime.runIfWaitingForDebugger' },
];

await session.send(commands);

// Break on start
await session.waitForBreakOnLine(
0, UrlResolve(session.scriptURL().toString(), 'main.js'));
await session.send([{ 'method': 'Debugger.resume' }]);

// Script loaded
await session.waitForBreakOnLine(
0, UrlResolve(session.scriptURL().toString(), 'main.js'));
await session.send([{ 'method': 'Debugger.resume' }]);

// Script loaded
await session.waitForBreakOnLine(
0, UrlResolve(session.scriptURL().toString(), 'dep.js'));
await session.send([{ 'method': 'Debugger.resume' }]);
}

async function runTest() {
const main = fixtures.path('inspector-instrumentation-breakpoint', 'main.js');
const child = new NodeInstance(['--inspect-brk=0'], '', main);

const session = await child.connectInspectorSession();
await testBreakpointBeforeScriptExecution(session);
await session.runToCompletion();
assert.strictEqual((await child.expectShutdown()).exitCode, 0);
}

runTest();

0 comments on commit a536d0d

Please sign in to comment.