Skip to content

Commit

Permalink
fs: add recursive watch to linux
Browse files Browse the repository at this point in the history
  • Loading branch information
anonrig committed Oct 21, 2022
1 parent fdadea8 commit a7b310d
Show file tree
Hide file tree
Showing 5 changed files with 364 additions and 20 deletions.
4 changes: 0 additions & 4 deletions doc/api/fs.md
Original file line number Diff line number Diff line change
Expand Up @@ -4377,10 +4377,6 @@ the returned {fs.FSWatcher}.
The `fs.watch` API is not 100% consistent across platforms, and is
unavailable in some situations.
The recursive option is only supported on macOS and Windows.
An `ERR_FEATURE_UNAVAILABLE_ON_PLATFORM` exception will be thrown
when the option is used on a platform that does not support it.
On Windows, no events will be emitted if the watched directory is moved or
renamed. An `EPERM` error is reported when the watched directory is deleted.
Expand Down
27 changes: 18 additions & 9 deletions lib/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ const {

const pathModule = require('path');
const { isArrayBufferView } = require('internal/util/types');
const linuxWatcher = require('internal/fs/linux_watcher');

// We need to get the statValues from the binding at the callsite since
// it's re-initialized after deserialization.
Expand All @@ -68,7 +69,6 @@ const {
codes: {
ERR_FS_FILE_TOO_LARGE,
ERR_INVALID_ARG_VALUE,
ERR_FEATURE_UNAVAILABLE_ON_PLATFORM,
},
AbortError,
uvErrmapGet,
Expand Down Expand Up @@ -161,7 +161,7 @@ let FileReadStream;
let FileWriteStream;

const isWindows = process.platform === 'win32';
const isOSX = process.platform === 'darwin';
const isLinux = process.platform === 'linux';


function showTruncateDeprecation() {
Expand Down Expand Up @@ -2297,13 +2297,22 @@ function watch(filename, options, listener) {

if (options.persistent === undefined) options.persistent = true;
if (options.recursive === undefined) options.recursive = false;
if (options.recursive && !(isOSX || isWindows))
throw new ERR_FEATURE_UNAVAILABLE_ON_PLATFORM('watch recursively');
const watcher = new watchers.FSWatcher();
watcher[watchers.kFSWatchStart](filename,
options.persistent,
options.recursive,
options.encoding);

let watcher;

// TODO(anonrig): Remove this when/if libuv supports it.
// libuv does not support recursive file watch on Linux due to
// the limitations of inotify.
if (options.recursive && isLinux) {
watcher = new linuxWatcher.FSWatcher(options);
watcher[linuxWatcher.kFSWatchStart](filename);
} else {
watcher = new watchers.FSWatcher();
watcher[watchers.kFSWatchStart](filename,
options.persistent,
options.recursive,
options.encoding);
}

if (listener) {
watcher.addListener('change', listener);
Expand Down
207 changes: 207 additions & 0 deletions lib/internal/fs/linux_watcher.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,207 @@
'use strict';

const { EventEmitter } = require('events');
const path = require('path');
const { SafeMap, Symbol, StringPrototypeStartsWith } = primordials;
const { validateObject } = require('internal/validators');
const { kEmptyObject } = require('internal/util');
const { ERR_FEATURE_UNAVAILABLE_ON_PLATFORM } = require('internal/errors');

const kFSWatchStart = Symbol('kFSWatchStart');

let internalSync;
let internalPromises;

function lazyLoadFsPromises() {
internalPromises ??= require('fs/promises');
return internalPromises;
}

function lazyLoadFsSync() {
internalSync ??= require('fs');
return internalSync;
}

async function traverse(dir, files = new SafeMap()) {
const { stat, opendir } = lazyLoadFsPromises();

files.set(dir, await stat(dir));

try {
const directory = await opendir(dir);

for await (const file of directory) {
const f = path.join(dir, file.name);

try {
const stats = await stat(f);

files.set(f, stats);

if (stats.isDirectory()) {
await traverse(f, files);
}
} catch (error) {
if (error.code !== 'ENOENT' || error.code !== 'EPERM') {
this.emit('error', error);
}
}

}
} catch (error) {
if (error.code !== 'EACCES') {
this.emit('error', error);
}
}

return files;
}

class FSWatcher extends EventEmitter {
#options = null;
#closed = false;
#files = new SafeMap();
#rootPath = path.resolve();

/**
* @param {{
* persistent?: boolean;
* recursive?: boolean;
* encoding?: string;
* signal?: AbortSignal;
* }} [options]
*/
constructor(options = kEmptyObject) {
super();

validateObject(options, 'options');
this.#options = options;
}

close() {
const { unwatchFile } = lazyLoadFsSync();
this.#closed = true;

for (const file of this.#files.keys()) {
unwatchFile(file);
}

this.emit('close');
}

#getPath(file) {
if (file === this.#rootPath) {
return this.#rootPath;
}

return path.relative(this.#rootPath, file);
}

#unwatchFolder(file) {
const { unwatchFile } = lazyLoadFsSync();

for (const filename of this.#files.keys()) {
if (StringPrototypeStartsWith(filename, file)) {
unwatchFile(filename);
}
}
}

async #watchFolder(folder) {
const { opendir, stat } = lazyLoadFsPromises();

try {
const files = await opendir(folder);

for await (const file of files) {
const f = path.join(folder, file.name);

if (this.#closed) {
break;
}

if (!this.#files.has(f)) {
const fileStats = await stat(f);

this.#files.set(f, fileStats);
this.emit('change', 'rename', this.#getPath(f));

if (fileStats.isDirectory()) {
await this.#watchFolder(f);
} else {
this.#watchFile(f);
}
}
}
} catch (error) {
this.emit('error', error);
}
}

/**
* @param {string} file
*/
#watchFile(file) {
const { watchFile } = lazyLoadFsSync();

if (this.#closed) {
return;
}

const existingStat = this.#files.get(file);

watchFile(file, {
persistent: this.#options.persistent,
}, (statWatcher, previousStatWatcher) => {
if (existingStat && !existingStat.isDirectory() &&
statWatcher.nlink !== 0 && existingStat.mtime.getTime() === statWatcher.mtime.getTime()) {
return;
}

this.#files.set(file, statWatcher);

if (statWatcher.birthtimeMs === 0 && previousStatWatcher.birthtimeMs !== 0) {
// The file is now deleted
this.#files.delete(file);
this.emit('change', 'rename', this.#getPath(file));

if (statWatcher.isDirectory()) {
this.#unwatchFolder(file);
}
} else if (statWatcher.isDirectory()) {
this.#watchFolder(file);
this.emit('change', 'change', this.#getPath(file));
} else {
this.emit('change', 'change', this.#getPath(file));
}
});
}

/**
* @param {string | Buffer | URL} filename
*/
async [kFSWatchStart](filename) {
this.#rootPath = filename;
this.#closed = false;
this.#files = await traverse(filename);

for (const f of this.#files.keys()) {
this.#watchFile(f);
}
}

ref() {
// This is kept to have the same API with FSWatcher
throw new ERR_FEATURE_UNAVAILABLE_ON_PLATFORM('ref');
}

unref() {
// This is kept to have the same API with FSWatcher
throw new ERR_FEATURE_UNAVAILABLE_ON_PLATFORM('unref');
}
}

module.exports = {
FSWatcher,
kFSWatchStart,
};
Loading

0 comments on commit a7b310d

Please sign in to comment.