Skip to content

Commit

Permalink
test: refactor test-crypto-hmac
Browse files Browse the repository at this point in the history
* replace assert.equals with assert.strictEquals
* use template strings where appropriate

PR-URL: #9958
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
eudaimos authored and Fishrock123 committed Dec 13, 2016
1 parent f08d8a6 commit a9d4bd7
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions test/parallel/test-crypto-hmac.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var h1 = crypto.createHmac('sha1', 'Node')
.update('some data')
.update('to hmac')
.digest('hex');
assert.equal(h1, '19fd6e1ba73d9ed2224dd5094a71babe85d9a892', 'test HMAC');
assert.strictEqual(h1, '19fd6e1ba73d9ed2224dd5094a71babe85d9a892', 'test HMAC');

// Test HMAC (Wikipedia Test Cases)
var wikipedia = [
Expand Down Expand Up @@ -67,9 +67,9 @@ for (let i = 0, l = wikipedia.length; i < l; i++) {
const result = crypto.createHmac(hash, wikipedia[i]['key'])
.update(wikipedia[i]['data'])
.digest('hex');
assert.equal(wikipedia[i]['hmac'][hash],
result,
'Test HMAC-' + hash + ': Test case ' + (i + 1) + ' wikipedia');
assert.strictEqual(wikipedia[i]['hmac'][hash],
result,
`Test HMAC-${hash}: Test case ${i + 1} wikipedia`);
}
}

Expand Down Expand Up @@ -233,10 +233,10 @@ for (let i = 0, l = rfc4231.length; i < l; i++) {
result = result.substr(0, 32); // first 128 bits == 32 hex chars
strRes = strRes.substr(0, 32);
}
assert.equal(rfc4231[i]['hmac'][hash],
result,
'Test HMAC-' + hash + ': Test case ' + (i + 1) + ' rfc 4231');
assert.equal(strRes, result, 'Should get same result from stream');
assert.strictEqual(rfc4231[i]['hmac'][hash],
result,
`Test HMAC-${hash}: Test case ${i + 1} rfc 4231`);
assert.strictEqual(strRes, result, 'Should get same result from stream');
}
}

Expand Down Expand Up @@ -356,7 +356,7 @@ if (!common.hasFipsCrypto) {
crypto.createHmac('md5', rfc2202_md5[i]['key'])
.update(rfc2202_md5[i]['data'])
.digest('hex'),
'Test HMAC-MD5 : Test case ' + (i + 1) + ' rfc 2202'
`Test HMAC-MD5 : Test case ${i + 1} rfc 2202`
);
}
}
Expand All @@ -366,6 +366,6 @@ for (let i = 0, l = rfc2202_sha1.length; i < l; i++) {
crypto.createHmac('sha1', rfc2202_sha1[i]['key'])
.update(rfc2202_sha1[i]['data'])
.digest('hex'),
'Test HMAC-SHA1 : Test case ' + (i + 1) + ' rfc 2202'
`Test HMAC-SHA1 : Test case ${i + 1} rfc 2202`
);
}

0 comments on commit a9d4bd7

Please sign in to comment.